search

vbmithr / ocaml-websocket

Websocket library for OCaml
ISC License
162 stars 44 forks source link

can't compile and can't install with opam #33

Closed zoggy closed 9 years ago

zoggy commented 9 years ago

Hello,

version 0.9.3 does not compile with tls 5.0:

File "tests/wscat.ml", line 49, characters 4-20:
Error: Unbound value Tls_lwt.rng_init

and current version in repository does not compile:

File "lib/websocket.ml", line 108, characters 4-16:
Error: Unbound value read_exactly

I signaled the second problem here: https://github.com/mirage/ocaml-cohttp/commit/e30f2927f09ab7c67853f0801cda57f48d7d50a6#commitcomment-11742886

I hope there will be new Cohttp/Websocket versions soon, as recent changes in tls/nocrypto/conduit resulted in a nightmare to install cohttp/websocket.

vbmithr commented 9 years ago

On 18/06/2015 11:39, Zoggy wrote:

https://github.com/mirage/ocaml-cohttp/commit/e30f2927f09ab7c67853f0801cda57f48d7d50a6#commitcomment-11742886

I hope there will be new Cohttp/Websocket versions soon, as recent changes in tls/nocrypto/conduit resulted in a nightmare to install cohttp/websocket.

I'm fixing this right now.

Vincent

vbmithr commented 9 years ago

Fixed in HEAD. An OPAM package is pending for release 2.0.0.

The API has changed, for the better I hope (no more Lwt streams), and the code is IMO of better quality and easier to reason about. Please test it and report any problem you may have with it.

zoggy commented 9 years ago

Damned, I liked the message streams. I will test right now. Thanks!