search

vbmithr / ocaml-websocket

Websocket library for OCaml
ISC License
162 stars 44 forks source link

makefile tweak for portability #4

Closed rgrinberg closed 11 years ago

rgrinberg commented 11 years ago

make install did not actually work for me with zsh. I think because of the brace expansion (it would not be expanded). I've made a fix to use pure make and not rely on any bashisms.

vbmithr commented 11 years ago

Thanks! Did not see the pull request!! I think I really have to do something about sorting my github mails. In the meantine, @yallop made a one line fix that is supposed to fix the issue, can you check if the new version is working now (also updated in opam). If it works, then I think @yallop solution is nicer.

rgrinberg commented 11 years ago

No problem, @yallop's fix is cleaner. Works for me btw.