search

vbmithr / ocaml-websocket

Websocket library for OCaml
ISC License
162 stars 44 forks source link

Default Rng generator #46

Closed zoggy closed 8 years ago

zoggy commented 8 years ago

Hello,

Websocket_lwt.establish_standard_server now takes a ~g parameter. Would it be possible to make it optional and use !Nocrypto.Rng.generator as in various places in tests/*ml ? This would prevent breaking API...

vbmithr commented 8 years ago

On 31/03/2016 00:02, Zoggy wrote:

|Websocket_lwt.establish_standard_server| now takes a |~g| parameter. Would it be possible to make it optional and use |!Nocrypto.Rng.generator| as in various places in |tests/*ml| ? This would prevent breaking API...

Ok, I did this in order to make obvious to the user that he has to provide a seeded generator. I could indeed make these optional. I think you might be right on this.

Vincent

zoggy commented 8 years ago

Thanks!