search

vbmithr / ocaml-websocket

Websocket library for OCaml
ISC License
162 stars 44 forks source link

RNG API cleanup #56

Closed j0sh closed 8 years ago

j0sh commented 8 years ago

Also improves the use of stdlib Random. CC @copy

@vbmithr if you think it's a good idea, I'll remove the cppo dep, and factor out other rng implementations as example code.

vbmithr commented 8 years ago

@j0sh @copy Well, now that you made this effort and that it is working (at least in what I tested), why not keep it? I don't mind the extra deps (it's only cppo right?). I suggest we keep it like this for now and factor our rng implementations in the future if we're unhappy about it at this time.

copy commented 8 years ago

I'd remove it rather now than later, later changes mean more effort for users. I think optional dependencies are a bad idea because they make the build process more complex and unpredictable. Either way, I don't have a very strong opinion on this.