search

vbmithr / ocaml-websocket

Websocket library for OCaml
ISC License
162 stars 44 forks source link

adapt to stdless Core / Async #81

Closed bmillwood closed 7 years ago

bmillwood commented 7 years ago

I actually don't expect you to merge this right away, because there's no official release of core and async that includes these changes. But the development version (as exposed in the janestreet opam overlay) already needs them to build, because while Std still exists, it is now deprecated, and we have warnings-as-errors turned on for this package. I'm using an opam pin to get this working and thought I might as well share the changes I made for that purpose.

Another approach that I'd also consider legitimate would be disabling deprecation-warnings-as-errors for the opam build. I don't immediately know how to do that but if you want me to cook it up I can give it a go.

bmillwood commented 7 years ago

Also maybe we need to include a version constraint with this change, but I'm vague on how to do that, too. The changesets that introduced the stdless way of doing things were janestreet/async@6515c2772c054da4549780af46ab949598a45c68 and janestreet/core@9db6603a2841a349adcac3ec69a18a32bc45c2cc

vbmithr commented 7 years ago

Hi. I indeed disabled warning-as-errors for deprecated features in commit ef79f61fd4ae3ce69ee26be09220b1a9ce45ddbd, though I did not release it so far.

vbmithr commented 7 years ago

Fixed via f73943286825c4df979ef113e728c9d8bb1ece4b. Thanks!