vbmithr / ocaml-websocket

Websocket library for OCaml
ISC License
162 stars 44 forks source link

async_ssl / websocket.2.9 need an upper bound somewhere #84

Closed avsm closed 4 years ago

avsm commented 7 years ago

Latest opam repository fails to combine websocket and async_ssl out of the box:

#=== ERROR while installing websocket.2.9 =====================================#
# opam-version 1.2.2
# os           linux
# command      ocaml pkg/build.ml native=true native-dynlink=true lwt=false async=true async_ssl=true nocrypto=false cryptokit=false test=false
# path         /home/opam/.opam/system/build/websocket.2.9
# compiler     system (4.04.0)
# exit-code    10
# env-file     /home/opam/.opam/system/build/websocket.2.9/websocket-27-6ed0d4.env
# stdout-file  /home/opam/.opam/system/build/websocket.2.9/websocket-27-6ed0d4.out
# stderr-file  /home/opam/.opam/system/build/websocket.2.9/websocket-27-6ed0d4.err
### stdout ###
# [...]
# File "lib/websocket_async.ml", line 252, characters 28-852:
# Error: The function applied to this argument has type
#          'a Async.Std.Deferred.Or_error.t ->
#          ('a -> 'b Async.Std.Deferred.Or_error.t) ->
#          'b Core_kernel.Std.Or_error.t Async_kernel.Types.Deferred.t
# This argument cannot be applied with label ~f
# Command exited with code 2.
# + ocamlfind ocamlopt -package unix -package ocamlbuild -linkpkg -package cppo_ocamlbuild myocamlbuild.ml /home/opam/.opam/system/lib/ocamlbuild/ocamlbuild.cmx -o myocamlbuild
# File "_none_", line 1:
# Warning 58: no cmx file was found in path for module Ocamlbuild_cppo, and its interface was not compiled with -opaque

versions of async_ssl are:

async                   113.33.00  Monadic concurrency library
async_extra        113.33.00+4.03  Monadic concurrency library
async_kernel            113.33.00  Monadic concurrency library
async_rpc_kernel        113.33.00  Platform-independent core of Async RPC library
async_ssl               113.33.07  An Async-pipe-based interface with OpenSSL.
async_unix         113.33.00+4.03  Monadic concurrency library
avsm commented 7 years ago

This is causing the docs.mirage.io build to fail, see https://hub.docker.com/r/unikernel/mirage/builds/bychhogn7quqyayxsnmh6mj/

vbmithr commented 7 years ago

Yep, indeed, I always test on janestreet bleeding edge. Will do, thanks!

vbmithr commented 7 years ago

I'll make a release when conduit/cohttp new flavour are released in opam.

copy commented 7 years ago

@vbmithr nudge (the new jbuilder-built cohttp and conduit packages are on opam.)

copy commented 4 years ago

Closing since this has been fixed a long time ago.