search

vboctor / disposable_email_checker

Project that tracks the list of domains that are open domains or disposable domains with libraries in multiple languages to consume such lists.
http://www.mantishub.com
MIT License
45 stars 19 forks source link

conditionally use APC cache, for blacklist file content #20

Open eduardev opened 7 years ago

vboctor commented 5 years ago

Thanks @eduardev for your contribution. I'm not sure of the benefit of using a cache here. Is there a measurable perf improvement here?

I have improved the latest implementation to use an associative array so checks for domains can be done in order of 1 instead order of N.

eduardev commented 5 years ago

Hi @vboctor sorry for the late answer... At the time I made that PR, I was working with a super high load application (+3M req/m), so, yeah it improved performance considerably as I/O is expensive