vbonvin / POUET

Programming Observations Usefully at Euler Telescope
GNU General Public License v3.0
1 stars 1 forks source link

Should we move away from PyEphem? #23

Closed kuntzer closed 6 years ago

kuntzer commented 6 years ago

I ran into weird behaviours that won't be changed see here: https://github.com/brandon-rhodes/pyephem/issues/102 this affects twilight times.

This package, by the same author seems to be bit more flexible: https://github.com/skyfielders/python-skyfield

To be reflected upon...

kuntzer commented 6 years ago

See also commit bf74d57cf898927b3f24c60d4dc81207c498a484

kuntzer commented 6 years ago

After thinking about it for some time, I think it's fine for now. There will be a ~2 min discrepancy between predictions of twilight times, so we should be fine.

vbonvin commented 6 years ago

Yep, we don't rely too heavily on this tbh, so let's keep PyEphem running.

2018-02-16 8:07 GMT+01:00 kuntzer notifications@github.com:

After thinking about it for some time, I think it's fine for now. There will be a ~2 min discrepancy between predictions of twilight times, so we should be fine.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/vbonvin/POUET/issues/23#issuecomment-366159716, or mute the thread https://github.com/notifications/unsubscribe-auth/ALsZrWqtlv0mjcbz1e3C_rk7DucL6KKVks5tVSkWgaJpZM4SHV7T . {"api_version":"1.0","publisher":{"api_key":" 05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity": {"external_key":"github/vbonvin/POUET","title":" vbonvin/POUET","subtitle":"GitHub repository","main_image_url":" https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88- 11e6-95fc-7290892c7bb5.png","avatar_image_url":"https:// cloud.githubusercontent.com/assets/143418/15842166/ 7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/vbonvin/POUET"}},"updates" :{"snippets":[{"icon":"PERSON","message":"@kuntzer in #23: After thinking about it for some time, I think it's fine for now. There will be a ~2 min discrepancy between predictions of twilight times, so we should be fine."}],"action":{"name":"View Issue","url":"https://github. com/vbonvin/POUET/issues/23#issuecomment-366159716"}}}

--

Vivien Bonvin Ph.D. in Observational Cosmology Ecole Polytechnique Fédérale de Lausanne (EPFL) - Laboratoire d'Astrophysique http://lastro.epfl.ch/ Observatoire de Sauverny - CH-1290 Versoix - Switzerland

kuntzer commented 6 years ago

Okay, agreed. Close for now.