Closed kuntzer closed 6 years ago
It is really slow. Must be fixed for version 0.3
Fixed it by doing less iterations when trying to measure the FWHM of the stars by fitting a Gaussian.
To go even faster, should use other ways of measuring FWHM, but I think it's acceptable now.
I got an error message related to this:
File "/home/vivien/work/pouet/pouet/clouds.py", line 98, in update
x, y = self.detect_stars()
File "/home/vivien/work/pouet/pouet/clouds.py", line 122, in detect_stars
image /= filters.gaussian_filter(np.nan_to_num(image), 10)
TypeError: unsupported operand type(s) for /: 'NoneType' and 'NoneType'
It worked for a few allsky refreshes and then crashed.
that's extremely weird. Do you have more info on this? I'll run pouet for a while and see if I can reproduce
Nope. Currently having pouet running as well but it's stable so far.
2018-07-06 9:31 GMT+02:00 kuntzer notifications@github.com:
that's extremely weird. Do you have more info on this? I'll run pouet for a while and see if I can reproduce
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/vbonvin/POUET/issues/57#issuecomment-402952009, or mute the thread https://github.com/notifications/unsubscribe-auth/ALsZraaDQsDVdiWYmIE10yFVJzvnpns3ks5uDxJagaJpZM4U5RBW . {"api_version":"1.0","publisher":{"api_key":" 05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity": {"external_key":"github/vbonvin/POUET","title":" vbonvin/POUET","subtitle":"GitHub repository","main_image_url":" https://assets-cdn.github.com/images/email/message_cards/header.png ","avatar_imageurl":"https://assets-cdn.github.com/images/email/message cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github. com/vbonvin/POUET"}},"updates":{"snippets":[{"icon":"PERSON","message":"@kuntzer in #57: that's extremely weird. Do you have more info on this? I'll run pouet for a while and see if I can reproduce"}],"action":{"name":"View Issue","url":"https://github.com/vbonvin/POUET/issues/57# issuecomment-402952009"}}} [ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": " https://github.com/vbonvin/POUET/issues/57#issuecomment-402952009", "url": "https://github.com/vbonvin/POUET/issues/57#issuecomment-402952009", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": " https://github.com" } }, { "@type": "MessageCard", "@context": " http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Re: [vbonvin/POUET] Faster all sky image analysis (#57)", "sections": [ { "text": "", "activityTitle": "kuntzer", "activityImage": " https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@kuntzer", "facts": [ ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"vbonvin/POUET\",\n\"issueId\": 57,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "name": "Close issue", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"vbonvin/POUET\",\n\"issueId\": 57\n}" }, { "targets": [ { "os": "default", "uri": "https://github.com/vbonvin/ POUET/issues/57#issuecomment-402952009" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 350556246\n}" } ], "themeColor": "26292E" } ]
Could not reproduce, added a fail safe at the line in question. It will be considered as an error in the log. Will close this issue for now. Re-open if it happens again.
OK. Same here, didn't happen again.
For now, it is embarrassingly slow. Find what is causing this and fix it.