search

vbpf / ebpf-verifier

eBPF verifier based on abstract interpretation
MIT License
389 stars 43 forks source link

Add CI/CD workflow to validate YAML files #618

Closed dthaler closed 5 months ago

dthaler commented 6 months ago

The intent is that this should run on a pull request and be required to pass before the pull request can be merged.

coveralls commented 6 months ago

Coverage Status

coverage: 90.374%. remained the same when pulling 1a45edd15f61c39f29475dd0e72af6502cb3744c on dthaler:validate-yaml into 4944945f8ba9071ef59240aabc37f0edbeae82c1 on vbpf:main.

elazarg commented 5 months ago

There are several check annotations in this PR. What should we do with them?

dthaler commented 5 months ago

There are several check annotations in this PR. What should we do with them?

My opinion: they are just warnings in strict mode, not errors so I left them as evidence that the workflow actually works and to demonstrate how potential issues can be seen in the Files view of github. If there were things that were actually invalid YAML, the workflow would fail. So my opinion is to leave warnings after manually verifying that the YAML looks fine, and only fix things flagged as errors.