search

vbr-calc / vbr

The Very Broadband Rheology Calculator (VBRc): for fitting experimental data and measured properties in the Earth's upper mantle!
MIT License
20 stars 15 forks source link

A small problem in Poroelasticity module #23

Closed wuzm-iggcas closed 2 years ago

wuzm-iggcas commented 2 years ago

Report for version: vbr-0.99.3 Dear authors, I accidentally found some inconsistency when comparing my own calculation with the output of 'anh_poro'. After going thorugh the related source code, I think the formulas taken from eqns A5-6, Takei 2002 (at Line 107 & 149, in el_ModUnrlx_MELT_f.m) have not been correctly quoted in the script, and should be corrected as follows: n_k = a_vec(1) . Psi + a_vec(2) . (1-Psi) + a_vec(3) . Psi . (1-Psi).^1.5 ; n_mu = b_vec(1) . Psi + b_vec(2) . (1-Psi) + b_vec(3) . Psi . (1-Psi).^2; Best, Zimu

chrishavlin commented 2 years ago

Thanks for the report! I'll check it out.

chrishavlin commented 2 years ago

Many thanks for catching that! I just created a pull request to fix it, it will get merged into master later today or tomorrow.