search

vbr-calc / vbr

The Very Broadband Rheology Calculator (VBRc): for fitting experimental data and measured properties in the Earth's upper mantle!
MIT License
20 stars 15 forks source link

bug fix: poroelastic scaling #24

Closed chrishavlin closed 2 years ago

chrishavlin commented 2 years ago

Fixing a typo in the poroelastic scaling. Closes #23

chrishavlin commented 2 years ago

Ran a quick comparison of what currently exists on master and the fixed version on this branch.

The following compares the unrelaxed modulus and Vs between master (black curves) and this branch (red curves):

Full range

And a zoom from phi = 0.001 to 0.05:

Mantle phi range

So not much impact until phi above a few percent and even then, I don't think this would propagate terribly to any bayes inferences as long as the allowed phi doesn't exceed ~0.05. Worst case, it would add around phi +/-0.01 at phi > 0.01.

So only a problem in the unlikely case that someone was using this calculation at unrealistically high melt fractions for the mantle.