vbr-calc / vbr

The Very Broadband Rheology Calculator (VBRc): for fitting experimental data and measured properties in the Earth's upper mantle!
MIT License
20 stars 15 forks source link

check on `eta_dry` for `visc_calc_xfit_premelt` #53

Closed chrishavlin closed 11 months ago

chrishavlin commented 1 year ago

from @jbrussell (thanks!!) :

"eta_dry" calculated in visc_calc_xfit_premelt is not necessarily "dry", it is just melt-free

I'm pretty sure this is simply of a poor choice of words where "dry" should be taken to mean "melt-free" rather than volatile-free. I'll check on that and change the variable names if that's the case.

chrishavlin commented 11 months ago

yup, it was indeed a badly chosen word... will rename this to eta_melt_free. The eta_dry_method parameter will be deprecated in favor of eta_melt_free_method