WIP: Adding Electrical Conductivity Methods

vbr-calc / vbr

The Very Broadband Rheology Calculator (VBRc): for fitting experimental data and measured properties in the Earth's upper mantle!

MIT License

20 stars 15 forks source link

WIP: Adding Electrical Conductivity Methods #73

Closed sammykojo closed 3 months ago

chrishavlin commented 8 months ago

Here's a list of things we'll want to do eventually before merging:

[ ] add a description to the pull request
[ ] add an example to Projects/vbr_core_examples
[ ] add a page to the full documentation describing methods
[ ] add to the automated test suite
[ ] add units metadata

chrishavlin commented 8 months ago

I'm going to try to push up the changes need to get this picked up by the automated methods in the Spine functions...

chrishavlin commented 8 months ago

Ok! @sammykojo I just pushed up a bunch of changes to your branch that get this working with all of the automated methods that the VBRc uses to call the functions. I also added an initial example, Projects/vbr_core_examples/CB_014_electrical_conductivity.m . Currently it errors, but it is properly picking up the new methods and functions. The errors should be fixed after you incorporate my latest review comments.

chrishavlin commented 8 months ago

Hey @sammykojo , with the latest changes, the example I added to this PR now runs with yosh2009 without error (the example at this path: Projects/vbr_core_examples/CB_014_electrical_conductivity.m). Something is going wrong in the calculation though -- after running that example, the sig fields in VBR.out.electric.yosh2009 are all inf or absurdly large. My first guess would be an issue with units or maybe a sign error in an exponential.

chrishavlin commented 5 months ago

Great to see the activity, @sammykojo ! let me know when you're ready for me to take another look.

chrishavlin commented 3 months ago

superseded by #92