search

vbuch / node-signpdf

Simple signing of PDFs in node.
MIT License
723 stars 178 forks source link

Feature/ add verify method #11

Closed MohammedEssehemy closed 6 years ago

MohammedEssehemy commented 6 years ago

Add support for verifying pdf files that contain a ByteRange placeholder.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 110

Totals Coverage Status
Change from base Build 107: 0.0%
Covered Lines: 112
Relevant Lines: 112
💛 - Coveralls
vbuch commented 6 years ago

Wow, @MohammedEssehemy , really a great contribution. I'll have a look at the code ASAP and probably suggest edits. Meanwhile, could you try and reach 100% of test coverage so that @coveralls doesn't complain :-) Also, without having seen any line of code so far, just asking you to stick to the purpose of the repo. You could've already written it correctly, so it is as readable as possible, but if you haven't, please, do. As I said, I will review it as soon as possible.

vbuch commented 6 years ago

I will wait for 1 more review until Monday-Tuesday before this gets merged just to make sure another pair of eyes have seen it. It is pretty cool at the moment. You could probably, if you have the time, add some comments on how verification is done. Also maybe some notes in the README? If you don't, I will do that once it is in develop before the new version is published. Thank you again for the great contribution!

MohammedEssehemy commented 6 years ago

Thanks for your review. I've added some notes to README