search

vbuch / node-signpdf

Simple signing of PDFs in node.
MIT License
688 stars 175 forks source link

Code linting #141

Closed dhensby closed 3 years ago

dhensby commented 3 years ago

I see that there is an eslint config and dependency but there's no lint command and it's not part of CI. This means there's quite a bit of code inconsistency in the repository.

I've added the linting command, linted the code and added linting to the CI (though it doesn't seem to be running on PRs).

I haven't made any changes to the linting rules / made any judgement about them and just made the code pass the linting command.

vbuch commented 3 years ago

Hm... interesting. Coveralls used to be hooked in. There used to be something with Travis as well, I think. Damn. I have to review stuff. Thank you for noticing! I'll probs merge this once I've figured what's happened with CI

vbuch commented 3 years ago

Since June 15th, 2021, the building on travis-ci.org is ceased. Please use travis-ci.com from now on.

dhensby commented 3 years ago

Ah yeah - I'm having this problem on node-mssql too :(