vbuch / node-signpdf

Simple signing of PDFs in node.
MIT License
679 stars 176 forks source link

Issue 183 signature is not pades compliant #187

Closed ElTimuro closed 1 year ago

ElTimuro commented 1 year ago

This solves: Issue 183

The validation result "The signature is not intact!" was caused by the wrong order of authenticatedAttributes in node-signpdf/src/signpdf.js.

This was found by @victorgrodriguesm7 here: https://github.com/vbuch/node-signpdf/issues/70#issuecomment-861435746.

I changed the order and validated the result using https://ec.europa.eu/digital-building-blocks/DSS/webapp-demo/validation and the certificate in /ressources.

image

image

ElTimuro commented 1 year ago

@vbuch just fixed the linting check

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4222073601


Totals Coverage Status
Change from base Build 4191872983: 0.0%
Covered Lines: 331
Relevant Lines: 331

💛 - Coveralls
cfranc0 commented 1 year ago

Is there a timeline for the release of the updated package via npm? Thanks!

vbuch commented 1 year ago

Taking it as a task and will try to do it by the end of the week. Sorry.

vbuch commented 1 year ago

1.5.1