Closed erikn69 closed 10 months ago
Back when this was actively develped I remember I somehow used the 'src' files. Actually, as stated in the README, back then the idea was not to make this a library. Little did I know on its usage. From my current point of view I'm totally fine with this but... it will be released as a major version as it cuts a lot from the package. Will get it released this way soon. Thanks for your PR.
Totals | |
---|---|
Change from base Build 5600970535: | 0.0% |
Covered Lines: | 331 |
Relevant Lines: | 331 |
it cuts a lot from the package
Yes, it does, but only when npm i node-signpdf
If you want to keep src on this version, I could separate the tests from the src folder
I like unit tests close to units. Also it does make total sense to omit src. So it will just be a a new version. Nothing much to it. It will be pretty safe to upgrade to it but I'll do it as a major just to make sure we don't break that 1 person using the /src files. I just need some time to check the project out, see what else is getting in this version, write a changelog and whatever a new version entails. Will do in the coming week or so.
Before
After