search

vbuch / node-signpdf

Simple signing of PDFs in node.
MIT License
719 stars 178 forks source link

Not working on Edge #66

Closed mfespuch closed 4 years ago

mfespuch commented 4 years ago

Hello! Thank you for the project first of all.

I have a problem running this library in Microsoft Edge, when I run my project shows an error in console at the beginning.

Screenshot_1

When debug I see the error here:

Screenshot_2

Do you know something about that?

Thank you for your help!

mfespuch commented 4 years ago

I noticed that the problem is with the spread operator, if all spreads operators change into Object.assign is working.

I am with an angular application, I don't know if is possible to when is compiling the app all spreads operators change into Object.assign...

vbuch commented 4 years ago

As you can see from the name of the project, it was initially done in node. I personally never tested it in a browser. I am surprised that's the only limitation in a browser. Yiu could make a PR to configure babel's building for browsers and node. See https://babeljs.io/docs/en/babel-preset-env#targetsbrowsers I never planned to make it work for browser, but since pdfsign.js points this way, the time may have come to do that. Again, a PR would be appreciated.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had activity in the past 90 days. It will be closed if no further activity occurs. Thank you for your contributions.