search

vbuch / node-signpdf

Simple signing of PDFs in node.
MIT License
719 stars 178 forks source link

Duplicated startxref and failed to search for AcroForm. #77

Closed therpobinski closed 3 years ago

therpobinski commented 4 years ago

Fix for diplicate startxref and fix in finding last ID of AcroForm.

therpobinski commented 4 years ago

Hello, I see that the changes have not been mixed yet. As I mentioned in the problem, there are some errors in testing. The truth is that those errors happened when I did a pull of the last changes of its default branch. Could you tell me what I can do to correct them?

therpobinski commented 4 years ago

I thought you never replied to this PR, I never got a notification. By reviewing your comments I will continue to resolve them. If I have a question with this comment, do you have any ideas or sources on how to get the length of the signature?

vbuch commented 4 years ago

@therpobinski read the note I linked. Just test it, Given the same certificate, the signature's lenght won't change. So just test it and find the needed length.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had activity in the past 90 days. It will be closed if no further activity occurs. Thank you for your contributions.