vburenin / ifacemaker

Generate interfaces from structure methods.
Apache License 2.0
320 stars 43 forks source link

cli: use jessevdk/go-flags for parsing options #31

Closed markus-wa closed 5 years ago

markus-wa commented 5 years ago

This currently depends on #30 (but that could be changed if necessary)

As you had mentioned in #28 there are currently quite a lot of deps due to https://github.com/mkideal/cli.

This PR replaces that lib with https://github.com/jessevdk/go-flags which is a bit more lightweight and somewhat more actively maintained.

I had to use a bit of a hack to make the -d flag work in the same way as today by making it a string argument, but now it should work.

I'll clean up the commit history etc. later this week but I'm filing the PR now so you can have a look (=> maybe wait with merging a bit).

vburenin commented 5 years ago

It looks so much less dependency heavy! Thanks Markus! Will need to try the latest version in our internal CI.

markus-wa commented 5 years ago

woops, meant to squash the fixup commits before merging, oh well 😅

vburenin commented 5 years ago

It is not that big of the project where it matters. I am seriously only care about that it works.