Open markus-wa opened 2 years ago
actually this is a bit of a bigger issue than I thought
option B doesn't seem to work
option A means to use the package with old versions the user has to manually git clone the repo, check out a good version and go install
further, v1.1.0 is a bit outdated. a new tag of the latest version with go1.11 compat (e.g. from maybe 2020 or early 2022?) would be very useful.
and PS: thanks a lot for maintaining the project :heart:
hi
this is just to inform that
master
now broke go1.11 compat. not sure if this is just a documentation issue, but v1.1.0 was working fine.I noticed this via my CI pipeline breaking: https://github.com/markus-wa/demoinfocs-golang/runs/6155103076?check_suite_focus=true
to repro, use
docker run -it golang:1.11
unfortunately go1.11 doesn't allow for specifying a specific version in GOPATH mode, so
GO111MODULE=off go get github.com/vburenin/ifacemaker@v1.1.0
doesn't fix the issuesome options to fix:
*/v2
(may need to revert master to v1.1.0 first, then do that and re-apply the changes since then. not sure how go handles it)Probably not worth doing option B as Go 1.11 is very old, so I'd go with option A or C.