Fixes signature_form for SIGHASH_SINGLE and SIGHAS_NONE.

vbuterin / pybitcointools

SImple, common-sense Bitcoin-themed Python ECC library

1.28k stars 856 forks source link

Open sr-gi opened 7 years ago

sr-gi commented 7 years ago

Fixes #149

signature_form for SIGHASH_SINGLE and SIGHASH_NONE for transactions with more than one input/output was not correctly created.

nSequence for inputs different than the signed index should be set to 0 in both cases.

Moreover, the whole format of SIGHASH_SINGLE was incorrect if a transaction with more than 1 input/output was created.

zilveer commented 6 years ago

Hi, why dont you guys merge this fix?

regards

sr-gi commented 6 years ago

Seems that no one is taking care of pull requests. Just two really basic ones have been merged throughout this year.