search

vc-bonn / Spline_PINN

91 stars 21 forks source link

Instruction fix code impr #2

Closed ykhas closed 2 years ago

ykhas commented 2 years ago

README.md:

source activate did not work before using linux - changed instructions to conda activate .... This should be a more robust, cross platform solution. Also mentioned that git-lfs is required.

wave_test.py: i%1==0 always returns true if i is an integer. I believe in this case i will always be an integer, since we are using a range() without specifying an interval. I think this can improve code readability - unless there is some case where i is not an integer :). I can also fix this in the fluid_test.py file - let me know!

wandeln commented 2 years ago

Hi Yaniv, thanks for your pull request! I just merged most of your comments manually. Best regards, Nils