Message Annotations content missing

vcabbage / amqp

AMQP 1.0 client library for Go.

https://godoc.org/pack.ag/amqp

MIT License

134 stars 98 forks source link

Message Annotations content missing #175

Open gavinfish opened 5 years ago

gavinfish commented 5 years ago

Related with Azure/azure-event-hubs-go#131.

After some investigation, I find that the msg received in the below method only has three Annotations: https://github.com/vcabbage/amqp/blob/7c41f1a1270d0d35b778b09b70c0e3063cd088af/client.go#L1810-L1839

annotation

The missing x-opt-partition-id annotation prevents the event hubs library to parse the partitionId for the event.

https://github.com/Azure/azure-event-hubs-go/blob/26616d904577c5d0b8c0a486b4b0e77c9c002284/event.go#L56-L62

vcabbage commented 5 years ago

Looking at a packet capture when receiving from Event Hubs I don't see x-opt-partition-id. Is there some thing extra that needs to be done to get EH to include that?

gavinfish commented 5 years ago

@devigned it seems that the x-opt-partition-id stuff is introduced in Azure/azure-event-hubs-go#108. Is there any documentation for this? I cannot find any test cases which will let the service side send this annotation.

devigned commented 5 years ago

I can’t find docs regarding x-opt-partition-id and at this point, I’m not sure if that was a meta field that previously existed or if it was a request to the service team to add the field. I’d reach out to the service team or other AMQP SDK teams for guidance.

This issue belongs in the Azure repos.