vcabbage / amqp

AMQP 1.0 client library for Go.
https://godoc.org/pack.ag/amqp
MIT License
134 stars 97 forks source link

Link name is not unique per connection. #196

Closed alanconway closed 4 years ago

alanconway commented 4 years ago

From the spec for link name:

"This name uniquely identifies the link from the container of the source to the container of the target node, e.g., if the container of the source node is A, and the container of the target node is B, the link MAY be globally identified by the (ordered) tuple (A,B,)."

So the name alone does not uniquely identify a link, you need the name and direction. Its legal for containers to assign the same name to links established in opposite directions (source-target direction, not which peer initiates the link) In the context of a single connection, the container-id pair (A,B) can be replaced by a boolean flag indicating the direction of the links.

Fixes #195

Signed-off-by: Alan Conway aconway@redhat.com

vcabbage commented 4 years ago

Good catch, thanks!