search

vcatalano / py-authorize

A full-featured Python API for the Authorize.net payment gateway.
MIT License
42 stars 35 forks source link

Added functionality to send amount when settling transactions #27

Closed aroraumang closed 10 years ago

aroraumang commented 10 years ago

@vcatalano Hi man. Thanks for this awesome API. In my pull request I have added the functionality to send amount when we settle transactions. Please respond if you want me to make any changes. I wonder why you didn't add this functionality, on the other hand I am happy to have contributed to your API.

PS: No idea why the Travis build is failing. Maybe, because of connection problem with "authorize.net". It fails with error "socket.error: [Errno 104] Connection reset by peer"

vcatalano commented 10 years ago

Thank you for your contribution, @aroraumang. All looks good!

In regards to the "Connection reset by peer" error, I get it quite frequently when I run the live tests. It's definitely an issue with their servers, usually running the tests a few more times on Travis CI fixes the problem.

aroraumang commented 10 years ago

Thanks.

I am looking for alternative to Travis due to such reasons. Tried droid.io, will switch to it maybe. You can also try it out.

vcatalano commented 10 years ago

So, today I was looking over the documentation changes for this request and I realized something. The new changes to the settle function call are not backwards compatible. I changed the settle function to now take an optional second "amount" parameter instead of a dictionary. This will prevent the changes from breaking existing applications.

Thanks again for your work on this.

aroraumang commented 10 years ago

Oops! How can I miss that. Thanks for fixing. The amount parameter sounds good.

And really sorry for the issue.

vcatalano commented 10 years ago

No worries @aroraumang. Thanks again for help on this issue.