vchlum / hue-lights

Gnome Shell extension for Philips Hue compatible lights controlled by the Philips Hue Bridge and for controlling Philips Hue HDMI sync box.
https://extensions.gnome.org/extension/3737/hue-lights/
MIT License
196 stars 14 forks source link

Icons look weird #54

Closed remcohaszing closed 2 years ago

remcohaszing commented 2 years ago

First of all: This is one of my favourite GNOME extensions! Thank you for making this!

On my system the icons look a bit weird. It looks like it’s having issues with the transparent parts. The icons look much better in the screenshot example in this project’s readme.

image

I don’t have this issue with other extensions or parts of GNOME.

image

I don’t recall whether this issue has always existed for me or not. Any idea what could be causing this? Is this a bug in the extension?

vchlum commented 2 years ago

Hi! My icons are sharp. This is not correct. I tuned up the blur of the icons in the early versions of the extension. No recent changes. I believe I know what it could be... I will look into it. I do not know how to reproduce your issue yet. What is your desktop scaling, resolution, and Linux distribution, please?

remcohaszing commented 2 years ago

My laptop is a System76 Oryx Pro running Pop!_OS 22.04. The resolution of my laptop screen is 1920x1080. I mostly have 2 additional monitors on leading to a total resolution of 3840x2160. The desktop scaling is 100%.

GNOME display settings

vchlum commented 2 years ago

I can not reproduce it in the VirtualBox instance yet. Could you please try the attached patch contrast.txt ? patch $HOME/.local/share/gnome-shell/extensions/hue-lights@chlumskyvaclav.gmail.com/phuepanelmenu.js contrast.txt Please, log out and log back in after patching...

remcohaszing commented 2 years ago

I applied it and did a full reboot just to be sure. Unfortunately this didn’t make a difference. I also made sure the patch is applied correctly by looking into the patched file, and it is.

vchlum commented 2 years ago

Hi again! I found out ... I hope:-) Do you use this extension?: https://extensions.gnome.org/extension/2878/transparent-top-panel/ Could you try to disable it?

vchlum commented 2 years ago

The extension 'Transparent Top Panel' can not deal with SVG icons. The extension also causes the odd background of icons representing GTK extendable menu items: image

remcohaszing commented 2 years ago

I do use that extension! And disabling it fixed the issue. Thanks for figuring that out! I was using that extension to get a transparent / black top panel. It’s not that important to me, so I’ll just disable it.

vchlum commented 2 years ago

Glad we got this. :-) I am closing this issue as solved. I do not intend to change the icon format.