vchrisb / Isilon-POSH

EMC Isilon Platform API implementation in PowerShell
MIT License
25 stars 13 forks source link

s/UserName,Password/Credential #2

Closed RamblingCookieMonster closed 9 years ago

RamblingCookieMonster commented 9 years ago

Nice looking module, looks great!

One small suggestion; it's a bit of a best practice to provide a Credential parameter in place of plaintext username and password parameters.

Let me know if you agree and would take a pull request, would be happy to submit one : )

Cheers!

vchrisb commented 9 years ago

Thx! :) I only thought about not passing the password with each cmdlet. Therfore I use the websession cookie with invoke-webrequest. But I didn't consider that passing the password in cleartext isn't a good thing at all.

Getting a pull request would be cool and my first one! :)

Cheers