Not properly sanitizing $BoundParameters before converting to JSON and sending in request body

[devblackops]

In your functions, you are taking $PSBoundParameters and converting it to a JSON string then sending it to the API. This causes unneeded properties to be sent with the request when the function is called with common parameters such as -Verbose or -Debug. The Isilon API responds with an error when these properties are sent.

Might I suggest you sanitize your properties before sending to the API? The function below will remove common properties.

function SanitizeBoundParameters {
    [cmdletbinding()]
    param(
        [parameter(Mandatory, ValueFromPipeline)]
        [hashtable]$Parameters
    )

    $commonParameters = @('Verbose', 'Debug', 'ErrorAction', 'ErrorVariable', 'WarningAction', 'WarningVariable',
        'OutBuffer', 'PipelineVariable', 'OutVariable')

    $commonParameters | % {
        $Parameters.Remove($_)
    }

    return $Parameters
}

This function could then be called like so:

$boundParameters = $PSBoundParameters | SanitizeBoundParameters
$body = ConvertTo-Json -Depth 40 $BoundParameters
$ISIObject = Send-isiAPI -Method POST -Resource ("/platform/1/quota/quotas" + "$queryArguments") -body $body -Cluster $Cluster

[vchrisb]

Great! I'll work the enhancement into Isilon-POSH-Generator and recreate all functions.

[vchrisb]

merged enhancement with Sanitize BoundParameters