search

vcmi-mods / swedish-translation

Swedish translation of Heroes of Might and Magic III: Complete Edition
0 stars 4 forks source link

Swedish translation not jet fully translated #4

Open XCOM-HUB opened 2 months ago

XCOM-HUB commented 2 months ago

Hi there @Fabrice-TIERCELIN! I use your translation mod for VCMI 1.5.7.

I wanted to help out. I have already started to help out @CalZing with his translation project here on GitHub (HeroesIIISwedish). Can I start helping you and CalZing to make this translation as good as possible?

heroesiiifan commented 2 months ago

@XCOM-HUB Of course you can help out to improve everything. Feel free to make a Pull Request. :)

But keep in mind: We've converted the original TXT files to JSON format (native VCMI translation format). So it's maybe a little bit double work to keep them in sync.

I think there was already some adjustments here: https://github.com/vcmi-mods/swedish-translation/pull/3

It would be also great if someone translates the launcher into swedish. Because it's the first thing you see from VCMI, when starting.

@CalZing A big thank for the project. :)

heroesiiifan commented 2 months ago

You can see a progress here: https://github.com/vcmi/vcmi-translation-status

I think it's not 100% for swedish correct because there are still english strings in json file.<

Feel free to ask if you need support.

XCOM-HUB commented 2 months ago

I'm new to making Pull Requests, but I'm willing to learn new things. Will VC Code be able to read JSON-files?

heroesiiifan commented 2 months ago

Yes of course!

You can basically also use the VS code integrated in GitHub.

Just open https://github.com/vcmi-mods/swedish-translation/blob/vcmi-1.4/swedish-translation/content/config/vcmi-swedish/game.json and use click on the arrow right of the edit button, then github.dev

or just use the link: https://github.dev/vcmi-mods/swedish-translation/blob/vcmi-1.4/swedish-translation/content/config/vcmi-swedish/game.json

After doing your changes you should do a commit (on 3. icon on left side). Then go back to github. It's asking you to make a Pull request.

Fabrice-TIERCELIN commented 1 month ago

Welcome @XCOM-HUB,

Here is a very detailled guide for submitting Pull Request to misiokles:

  1. Create the files you want to add/change on the project of a town mod on your computer
  2. Go on the GitHub page of the mod
  3. Click on the Code tab
  4. Click on the Fork grey button
  5. Click on the Create fork green button
  6. Go to your repositories page
  7. Click on your project
  8. Click on the Code tab
  9. Click on the folders where you want to add/change a file
  10. In the right folder, click on the Add files grey button
  11. Drag and drop your new/modified files from your computer to the web page
  12. Add a commit message
  13. Click on the Commit changes green button
  14. Click on the Compare changes green button in the brand new orange banner
  15. Mention misiokles in the description
  16. Click on the Create Pull Request green button

Once the Pull Request is merged by misiokles, you can remove your fork:

  1. Go to your repositories page
  2. Click on your project
  3. Click on the Settings tab
  4. Click on Delete this repository
  5. Confirm to delete

Now, you are ready to do another Pull Request. Note that this method only allows you to submit files on the same folder of the project.

XCOM-HUB commented 1 month ago

Is my recent Pull Request good to go?

Fabrice-TIERCELIN commented 1 month ago

I think you are talking about this PR: https://github.com/vcmi-mods/swedish-translation/pull/7

To disambiguate, I advise you to paste the URL of the PR in your comment.

You have clicked on Close, which means that any other person should ignore it. If you want your PR to be reconsider, click on Reopen. It works but if you want your PR not to be merged for now, you can click on the draft link on the right. Then, when your PR is ready, you click on Ready for review.