search

vcmi / vcmi

Open-source engine for Heroes of Might and Magic III
https://vcmi.eu/
GNU General Public License v2.0
4.19k stars 459 forks source link

Loaded random map complains about non-existent hero #3508

Open DjWarmonger opened 7 months ago

DjWarmonger commented 7 months ago

Describe the bug Client console shows errors about unknowns hero alach from Asylum mode. However, I've had Asylum mod disabled all the time - at map generation and now on launching the game.

Game logs

Too new map format revision: 1. This map should work but some of map features may be ignored. Failed to resolve identifier 'a_alach' of type 'hero' from mod 'game' Identifier 'a_alach' of type 'hero' does not exists in any loaded mod! Map MAPS/VIALOFDRAGONBLOODTEST is invalid. Message: Failed to resolve identifier asylum-town:a_alach

To Reproduce

  1. Have Asylum mod installed, but disabled.
  2. Generate random map - Jebus will do.
  3. Exit to main menu
  4. Go to "new game" menu, select previously generated map
  5. Observe error

Expected behavior No error message should show,

Actual behavior Confusing error mesage,

Did it work earlier? No idea

Version 1.4.2

Additional context Might be related to https://github.com/vcmi/vcmi/issues/3295 , as the other error shows just below in same scenario.

IvanSavenko commented 7 months ago

Are you sure that this is warning for your new maps?

If you have old maps created with Asylum vcmi will attempt to load them for map list in screnario selection and fail due to missing mod object

DjWarmonger commented 7 months ago

I just deleted all the random maps before trying.

DjWarmonger commented 2 months ago

Tried to reproduce, now generated maps don't show on map list at all.