vcombey / fallible_collections

impl fallible collections in rust, quite as describe in RFC 2116
Apache License 2.0
31 stars 14 forks source link

Make hashbrown dependency optional #32

Closed cccs-ki closed 1 year ago

cccs-ki commented 1 year ago

I'd like to use the Box part of this library, however I don't want to bring in any dependencies. I think there should be a feature called "hashmap" which gets added to the default features, but is required to use hashbrown and the hashmap functionality.

Thus, removing the feature should remove hashbrown as a dependency.

baumanj commented 1 year ago

Hashbrown is already the default for rust stdlib, so unless you’re using nostd, it’s not adding any new dependencies

cccs-ki commented 1 year ago

While the stdlib does use hashbrown, the dependency will still be downloaded and compiled, thus being one more package that needs to be vendored.