search

vcombey / fallible_collections

impl fallible collections in rust, quite as describe in RFC 2116
Apache License 2.0
31 stars 14 forks source link

Fallible only types #4

Closed baumanj closed 4 years ago

baumanj commented 4 years ago

This is based on https://github.com/vcombey/fallible_collections/pull/3, so you can ignore the first commit for now and just look at https://github.com/vcombey/fallible_collections/commit/7e62b06ec26420c9f40cbe847830e96bff379ff1. I'll rebase after https://github.com/vcombey/fallible_collections/pull/3 is merged, but I wanted to put this here since I've already completed the work.

vcombey commented 4 years ago

we could also implement TryClone for TryVec, TryBox... what do you think ?

baumanj commented 4 years ago

we could also implement TryClone for TryVec, TryBox... what do you think ?

Sounds good! Done in https://github.com/vcombey/fallible_collections/pull/4/commits/57ed9a3e82ab0fa1b5f625afa5428c1d75530f44

baumanj commented 4 years ago

I think I've addressed all your feedback. I'll need to rebase this after https://github.com/vcombey/fallible_collections/pull/3 merges, but I wanted to wait on that until we're done reviewing the changes here since the force push required destroys the continuity of the review conversation.

baumanj commented 4 years ago

I rebased this and added some tests for try_clone. Once you merge this, can you publish a new version to crates.io? I think that's all I should need on your side to continue with https://bugzilla.mozilla.org/show_bug.cgi?id=1624698.