search

vcristiani / galaxy-chop

MIT License
5 stars 2 forks source link

Implementation of the decomposition method using… #125

Closed vcristiani closed 3 years ago

vcristiani commented 3 years ago

… gaussian mixture models and tests.

nvillagra commented 3 years ago

Line 7 of models.py ( """Module models."""). Is the model GCgmm missing?

I think that I do not understand which is the function of the module.

Same here :raised_hand:

RafaelPignata622 commented 3 years ago

Line 7 of models.py ( """Module models."""). Is the model GCgmm missing?

I think that I do not understand which is the function of the module.

I do not understand the question. The module models.py contains all the decompositions methods, including the new Gaussian Mixture.

In line 7 says that it is the "Module models" because it is the module of models, I think that the right way is the "Methods module" but anyway for another time.

nvillagra commented 3 years ago

Line 7 of models.py ( """Module models."""). Is the model GCgmm missing? I think that I do not understand which is the function of the module.

I do not understand the question. The module models.py contains all the decompositions methods, including the new Gaussian Mixture.

In line 7 says that it is the "Module models" because it is the module of models, I think that the right way is the "Methods module" but anyway for another time.

My question was if GCgmm() shouldn't be listed in

all = [ "GCDecomposeMixin", "GCClusterMixin", "GCAbadi", "GCChop", "GCKmeans", ] ?

vcristiani commented 3 years ago

Line 7 of models.py ( """Module models."""). Is the model GCgmm missing?

I think that I do not understand which is the function of the module.

Refers to the name of the module. That is to say, this module contains all the models used in the dynamic decomposition. We did not use the word methods because it sounded ambiguous.

vcristiani commented 3 years ago

Line 7 of models.py ( """Module models."""). Is the model GCgmm missing? I think that I do not understand which is the function of the module.

I do not understand the question. The module models.py contains all the decompositions methods, including the new Gaussian Mixture. In line 7 says that it is the "Module models" because it is the module of models, I think that the right way is the "Methods module" but anyway for another time.

My question was if GCgmm() shouldn't be listed in

all = [ "GCDecomposeMixin", "GCClusterMixin", "GCAbadi", "GCChop", "GCKmeans", ] ?

Yes, it should be. Thank you for noticing.