search

vcristiani / galaxy-chop

MIT License
5 stars 2 forks source link

this solves issues #62 #65

Closed vcristiani closed 4 years ago

vcristiani commented 4 years ago

I implemented the calculation of the specific gravitational potential energy with dask, in the energy method. The function is in the file utils.py.

BrunoSanchez commented 4 years ago

I think that to review this I will end up cloning the branch and figure out how is it running. I would like to encourage the team to accept this PR only when testing for this great implementation is passing.

I think that we are doing a great job but we need to put effort into testing, until we reverse the process and truly achieve TDD.

ornemarioni commented 4 years ago

I have made the test of the potential function implemented with dask. This fixes issue #64