search

vcristiani / galaxy-chop

MIT License
5 stars 2 forks source link

modification of the aling function to correct the way it works #74

Closed vcristiani closed 4 years ago

vcristiani commented 4 years ago

Now the function rotates all the particles with only one rotation matrix.

antotaverna commented 4 years ago

I think that the changes are ok. However I don't know why the travis fail.

nvillagra commented 4 years ago

Is it necessary to have as inputs the masses of the dark matter and the gas?

vcristiani commented 4 years ago

@antotaverna Yes, but I see that now it does not fail more.

vcristiani commented 4 years ago

@nvillagra Now that you mention it, there's no need. I modify and upload it.

vcristiani commented 4 years ago

@antotaverna @nvillagra I added the modifications that @nvillagra suggested.

vcristiani commented 4 years ago

Modification of the aling function