search

vcsjones / AzureSignTool

SignTool Library and Azure Key Vault Support
MIT License
272 stars 85 forks source link

Addition of an option to throttle the signing requests. #159

Open hikariuk opened 2 years ago

hikariuk commented 2 years ago

Even with the -mdop option set to 1 I still periodically get errors from timestamp servers, so this option attempts to add another tool to the chest to prevent this.

hikariuk commented 2 years ago

In theory I like this idea, but I do not think AzureSign.Core should be changed. This seems more like a change with how AzureSignTool interacts with AzureSign.Core. AzureSign.Core's job is to just sign things, unaware of its surroundings.

I'll shift the changes to the loop. Makes the changes a bit simpler too, really.

wizgob commented 1 year ago

Is this possible to validate this PR? I also experience throttling with my timestamp provider.