vcsjones / AzureSignTool

SignTool Library and Azure Key Vault Support
MIT License
285 stars 89 forks source link

Signing installer changes product name to "Sign a file." only in UAC #257

Closed krachynski closed 5 months ago

krachynski commented 5 months ago

I discovered this after our CI/CD pipeline spit out an installer that apparently is named "Sign a file."

For most of our signatures, we're signing DLLs or EXEs. For one set of projects, we're also signing the installer EXE out of band. We will be moving the signature to the installer project itself eventually, but for right now, we need to address this particular issue. Can't have our clients trying to install "Sign a file." when they expect to see "Product Catalog Installer" instead.

The weirdest part is that I can't see this name anywhere except in a UAC prompt. It doesn't show up in the SysInternals SigCheck or Explorer's Properties Details tab.

I created a sample project in my installer toolkit. image

If I install this, I get the expected information. image

Once it's been signed, however. image

Previously we were using signtool with a USB-based EV Certificate. This resulted in this view of the installer in UAC image

I've gone rooting through the code and I just don't see how the description for your sign Command got inserted.