search

vcsjones / AzureSignTool

SignTool Library and Azure Key Vault Support
MIT License
267 stars 85 forks source link

Add the correct description #259

Open krachynski opened 2 months ago

krachynski commented 2 months ago

fixes #257

This code was adding the AzureSignTool Command.Description to the signed file. Sending null allows the codesigning to reuse the existing description.

krachynski commented 2 months ago

Err. I mean it's grabbing the Command.Description and overriding the data in the file being signed.

vcsjones commented 2 months ago

I think this was a bug in 5.0.0. I don't think we should stop setting Description all together. Can you try building from main and see if AST properly uses Description (-d)?

krachynski commented 1 month ago

This was from main.

If you have a better way to handle this, I'm open to suggestions. This fixed my fork for my needs.

krachynski commented 1 month ago

PS: The original code is adding the Command.Description ("Sign a file.") to the signed object. Which isn't correct in itself.