search

vcstools / rosinstall

Other
10 stars 21 forks source link

Add fake identity for VCSs #107

Closed jspricke closed 7 years ago

jspricke commented 7 years ago

This makes the unit tests self contained.

wjwwood commented 7 years ago

@jspricke I pruned the list of Python versions (no longer supported) and that should address one of the CI setup problems. But it looks like git is failing in many of the tests with the "Tell me who you are" error.

jspricke commented 7 years ago

Same as for wstool, all tests results are gone.

wjwwood commented 7 years ago

Ok, I finally got the tests running again. I think the remaining failures are related to your changes. If you like I can take my changes to get the tests working and put them on a separate pr.

But either way, please have a look at the remaining failures.

jspricke commented 7 years ago

Fixed. Thanks for working on the Travis part.

wjwwood commented 7 years ago

@jspricke I believe it is working here, because the tests are laid out in a more conventional way (everything in files starting with test_ in the folder test).

wjwwood commented 7 years ago

Oops, posted the comment on the wrong issue...