vcstuff / sd-jwt-vc-types

Other
1 stars 1 forks source link

Potentially illegal configurations #4

Open jogu opened 7 months ago

jogu commented 7 months ago

I think some configurations should be illegal but I'm not sure the spec says that today. An example would be an 'address' object that is marked authoritative, but also has a field within it that's marked as self-attested, i.e.

 "claims":{
    "/address":{
      "display":{
        "en-US":{
          "label":"Address",
          "description":"Address at the time of graduation"
        }
      },
      "verification":"authoritative",
      "sd":"always"
    },
    "/address/street_address":{
      "display":{
        "en-US":{
          "label":"Street Address"
        }
      },
      "verification":"self-attested",
      "sd":"always"
    }

I think that probably shouldn't be allowed, it feels difficult to verifiers to reason about.

babisRoutis commented 5 months ago

Perhaps, there should be some rules for the verification values of sub-claims.

Some ideas :

Furthermore, would it make sense to have a top-level optional verification attribute, effectively marking all claims ? For example, marking all claims of PID or mDL as authoritative