Commit Issue ••• Node Mover Tool: Moving Files Error

[touwys]

First observation: There is not method available in this commit to Multi-select files?

Secondly, the new progress indicator looks good and works well, thank you!

Thirdly, the issue: When files are moved from source, they do not show up at their destination: • • • • •

[touwys]

Here follows another example: • • • • •

[vctfence]

Ok, there's a bug for moving, let's try copy at first. See multi-selection by SHIFT+click:

Just click the second node with SHIFT pressed.

[touwys]

Copy Files = √

Shift + Click Multiselect = √

[vctfence]

Moving should have been fixed in commit 1a1f0318dd1b1639062159fddd809e47da8ed576.

[touwys]

_Moving should have been fixed in commit 1a1f031._

I confirm that moving nodes between the two NMT panels/trees is now fixed — thank you.

It is, however, impossible to move — or copy — nodes to the root of the target panel, under these conditions:

1. While a node is selected/active in the target panel, but its radio-button is not enabled.

2. While there are no files occupying the root.

I could not figure out out how to deselect the active node in the target panel to activate the root. If such a function is not yet available, please consider this:

Move or copy files only on condition that a radio-buttion is enabled in the target panel. Merely selecting a node (i.e with the radio-buttons disabled) shoud not justify the move/copy action. If there are no files occupying the root of the target panel, merely click on an empty space inside the panel to deselect an active node having a disabled radio-button. • • •

[vctfence]

Try ed63d2dff0caa4e5283c3, which show root node always.

[touwys]

Hello Victor,

OK, that is a quick and good solution for me, but keep in mind that not everybody knows what "root" means, and what it is there for.

I also noticed that the folder that are getting moved do arrive at the target panel, but it still leaves a "blank" copy of each file at the source panel. These "blanks" plainly open on a browser page that reads: "404 page not found". Has this not been fixed in https://github.com/vctfence/scrapbee/commit/ed63d2dff0caa4e5283c39acabe44b0cf764e16d ed63d2d?

Pierre

From: vctfence [mailto:notifications@github.com] Sent: 04 December 2020 03:23 To: vctfence/scrapbee scrapbee@noreply.github.com Cc: touwys admores@gmail.com; Author author@noreply.github.com Subject: Re: [vctfence/scrapbee] Commit Issue ••• Node Mover Tool: Moving Files Error (#64)

Try https://github.com/vctfence/scrapbee/commit/ed63d2dff0caa4e5283c39acabe44b0cf764e16d ed63d2d, which show root node always.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/vctfence/scrapbee/issues/64#issuecomment-738490641 , or unsubscribe https://github.com/notifications/unsubscribe-auth/APVPQQUEKMG6EAS73NADOMLSTA2ZBANCNFSM4UCITYIA . https://github.com/notifications/beacon/APVPQQV74D4KZGRGFRKBKZLSTA2ZBA5CNFSM4UCITYIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFQCHSEI.gif

[vctfence]

leaves a "blank" copy of each file

Have not been checked, please discuss problems in their own issue.

[vctfence]

Pushed d33bc7087144af330aec56078d11dcc233e89dbb, let user toggle visibility of root node, should be enough.

[touwys]

Checked, but although it works, it's still too "complicated" for something that doesn't really need such a complex way just to deselect a node. Is it impossible to get the app to simply deselect the more intuitive way, by simply clicking in an empty space in the panel?

(Note: Commit d33bc70 has not yet fixed the file move issue? Is that correct?)

[vctfence]

Commit for this issue includes just changes for this issue (usually), please discuss current issue here.

We have talked about the disadvantage of deselecting nodes, and I think showing a root node is an even more clear/friendly/convenient method and I think it's easy to understand.

[vctfence]

In fact, if you try Scrapbook(for Firefox <= 56), you'll find the author think in same way, the focus won't lost when user click on empty space of sidebar.

[vctfence]

Also, you can see root node in Scrapbook, while selecting saving position:

[touwys]

Scrapbook is a mature app, and a very good example to emulate.