search

vctfence / scrapbee

Mozilla Public License 2.0
39 stars 23 forks source link

Works with IceCat, please allow running #95

Closed ivilata closed 1 year ago

ivilata commented 2 years ago

Hi, first of all thanks for the very useful extension! :vulcan_salute:

I tried to install ScrapBee on GNU IceCat 91.6.0esr (from GNU Guix) and it reported "Your browser or version is not supported" on stderr. With the extension debugger, I forced compatible = true after here and the extension seems to work with no issues. I can start the external process, capture pages, open pages, and sort them as expected.

I suggest adding a line:

compatible = compatible || (info.name == "IceCat" && main_version >= 57);

to allow using the extension with IceCat. Thank you very much! :smile:

ivilata commented 2 years ago

For the sake of completeness, IceCat is a Firefox fork by the GNU project, with privacy and software freedom enhancements. It sticks to Firefox' version numbering.

ivilata commented 1 year ago

I loaded commit 13beec71 of ScrapBee as a temporary add-on and it seems to work without issues in IceCat, so this issue may be closed.

Thanks @vctfence!

ivilata commented 1 year ago

Thank you very much! :slightly_smiling_face: