search

vczh-libraries / GacUI

GPU Accelerated C++ User Interface, with WYSIWYG developing tools, XML supports, built-in data binding and MVVM features.
Other
2.34k stars 298 forks source link

GacGen/NativeController.cpp should be removed from CMakeLists.txt #103

Closed jimwang118 closed 2 months ago

jimwang118 commented 2 months ago

The NativeController.cpp file does not exist in the project and should be deleted from the Tools/GacGen/CMakeLists.txt compilation file.

vczh commented 2 months ago

I will close this as won't fix since a more elegant solution is available as I have commented in the vcpkg link above.

BillyONeal commented 2 months ago

I will close this as won't fix since a more elegant solution is available as I have commented in the vcpkg link above.

I'm not sure what is more 'elegant' in your description; we use upstream's build system unless it is entirely unusable for some reason because we aren't the maintainers and often our forked build systems are a source of mistakes that confuse library authors and users.

vczh commented 2 months ago

@BillyONeal The problem of the last version is that, vcpkg used source files from 4 repos at the same time. This is not right because no one can ensure the 4 commits taken from 4 repo are sync. But at that moment I didn't solve this issue for some reason.

Now the blocking issue preventing vcpkg from using source files from only one Release repo has gone. These CMakeLists.txt are in other repos, so they can't be used anymore. I use vcxproj instead of cmake to build my repo, but even if cmake is better, these files should be in the Release repo. So deleting them from this GacUI repo is going to happen anyway.

https://github.com/vczh-libraries/Release/tree/master/Tools/Executables here is the expected location for these source files, instead of files in this repo (https://github.com/vczh-libraries/GacUI/tree/master/Tools/GacGen), and others.