Closed kpango closed 4 months ago
[!WARNING]
Rate Limit Exceeded
@kpango has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 1 minutes and 1 seconds before requesting another review.
How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.Commits
Files that changed from the base of the PR and between 91475b4aa745984039cd43211adc2f13ef5786b0 and 6dee89987d994a1e67fbe209194db9ac9233d8c0.
The repository has undergone extensive updates, primarily focused on enhancing security and reliability in file downloads across various Makefiles, with the addition of -fsSL
flags to curl
commands. This update also includes Kubernetes version bumps in GitHub templates and the introduction of new Dockerfiles and Rust components. Changes in GRPC configurations and dependency updates in Go modules are also notable, alongside modifications to improve logging and error handling in script executions.
Files | Change Summary |
---|---|
.github/ISSUE_TEMPLATE/* , .github/PULL_REQUEST_TEMPLATE.md |
Updated Kubernetes version from v1.29.3 to v1.30.0 . |
Makefile , Makefile.d/* |
Added -fsSL options to curl commands for enhanced security and reliability. Introduced changes in version file logging and handling in scripts. |
docs/tutorial/* , docs/user-guides/deployment.md |
Updated curl commands in Helm installation instructions to use -fsSL . |
example/client/go.mod.default , hack/go.mod.default |
Updated Go and Kubernetes related dependencies to newer versions. |
internal/config/* , internal/net/grpc/* |
Adjustments in GRPC configuration methods and test cases, including error handling and ticker management for health checks. |
dockers/* , rust/* |
Added new Dockerfiles and initiated Rust components with necessary configurations and source files. |
Various .md and .mk files |
General enhancements in logging, error display, and download command options across documentation and Makefiles. |
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
[CHATOPS:HELP] ChatOps commands.
/approve
- approve/format
- format codes and add licenses/gen-test
- generate test codes/label
- add labels/label actions/e2e-deploy
- run E2E deploy & integration test[WARNING:INTCFG] Changes in interal/config
may require you to change Helm charts. Please check.
Attention: Patch coverage is 14.81994%
with 615 lines
in your changes are missing coverage. Please review.
Project coverage is 18.91%. Comparing base (
9e091b1
) to head (6dee899
). Report is 7 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Latest commit: |
6dee899
|
Status: | ✅ Deploy successful! |
Preview URL: | https://e0d86aef.vald.pages.dev |
Branch Preview URL: | https://feature-gateway-lb-add-effic.vald.pages.dev |
@coderabbitai review
[FOSSA] The scan result will be available at https://app.fossa.com/projects/custom%2B21465%2Fvald/refs/branch/feature%2Fgateway-lb%2Fadd-efficient-search-for-large-topk-query/1eccb8cbfd8bc715396c2b0370b13df233d445fb
type | vald-agent-ngt | vald-lb-gateway | vald-discoverer | vald-manager-index |
---|---|---|---|---|
cpu | ![]() | ![]() | ![]() | ![]() |
heap | ![]() | ![]() | ![]() | ![]() |
@coderabbitai review
@coderabbitai review
type | vald-agent-ngt | vald-lb-gateway | vald-discoverer | vald-manager-index |
---|---|---|---|---|
cpu | ![]() | ![]() | ![]() | ![]() |
heap | ![]() | ![]() | ![]() | ![]() |
Description
In the current Vald search architecture, each agent receives and processes queries broadcasted by the load balancer (LB) exactly as they are received. For example, with a configuration of Top-K=10 and Agent Replica=5, the LB reduces the results from 50 (produced collectively by the agents) down to the top 10.
However, when the Top-K value is extremely high, such as 100,000, it is inefficient to search across all K multiplied by the number of replicas. To address this, we have developed a feature that adjusts the number of requests forwarded to the agents based on a configurable ratio.
This pull request introduces a 'Ratio' setting within the Search Config. This setting allows for the dynamic adjustment of the proportion of the Top-K results that are propagated to the agents. If the 'Ratio' is not configured or set to 1, the system will maintain the current behavior of forwarding 100% of the Top-K results. If set to 0.5, only 50% of the Top-K will be searched. Conversely, setting the Ratio to 1.2 will result in 120% of the Top-K being searched, effectively increasing the breadth of the search under certain conditions.
Related Issue
Versions
Checklist
Special notes for your reviewer
Summary by CodeRabbit
New Features
v1.30.0
.-fsS
and-fsSL
options across multiple Makefiles for improved security and reliability.curl
options.Bug Fixes
golangci-lint
,reviewdog
,kubectl
, andbuf
.Documentation
1.22.2
to1.22.3
.Refactor