kmrmt commented 3 months ago

Description

Update ratio handling with large top-K. Merge the logic ratio is 0 and ratio is less than 0.

Related Issue

Versions

Go Version: 1.22.3
Rust Version: 1.77.2
Docker Version: 20.10.8
Kubernetes Version: v1.30.0
NGT Version: 2.2.1

Checklist

[x] I have read the CONTRIBUTING document and completed our CLA agreement.
[x] I have checked open Pull Requests for the similar feature or fixes?

Special notes for your reviewer

Summary by CodeRabbit

Bug Fixes
- Improved calculation logic for numerical values to handle edge cases where the ratio is zero.

coderabbitai[bot] commented 3 months ago

Walkthrough

## Walkthrough The `calculateNum` method in the `server` struct within `handler.go` was updated to refine the logic handling the `ratio` parameter. The condition was changed from `if ratio < 0.0` to `if ratio <= 0.0`, thereby removing the separate check for `ratio == 0.0` and adjusting the calculation of `n` accordingly. ## Changes | File Path | Change Summary | |--------------------------------------------|------------------------------------------------------------------| | pkg/gateway/lb/handler/grpc/handler.go | Updated `calculateNum` method: changed condition from `if ratio < 0.0` to `if ratio <= 0.0`, removed `if ratio == 0.0`, and adjusted calculation of `n`. | ## Sequence Diagram(s) (Beta) ```mermaid sequenceDiagram participant Client participant Server Client->>Server: Call calculateNum(num, ratio) alt ratio <= 0.0 Server-->>Client: Return n based on adjusted calculation else ratio > 0.0 Server-->>Client: Return n based on ratio end ``` This sequence diagram illustrates the interaction between the Client and Server when the `calculateNum` method is called. The diagram shows the decision-making process based on the value of `ratio` and the corresponding return value of `n`.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

vdaas-ci commented 3 months ago

[CHATOPS:HELP] ChatOps commands.

:ok_woman: /approve - approve
:bento: /format - format codes and add licenses
:white_check_mark: /gen-test - generate test codes
:label: /label - add labels
:end: :two: :end: /label actions/e2e-deploy - run E2E deploy & integration test

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 18.90%. Comparing base (6d4b505) to head (99b3333). Report is 9 commits behind head on main.

Files	Patch %	Lines
pkg/gateway/lb/handler/grpc/handler.go	0.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2509 +/- ## ========================================== - Coverage 18.92% 18.90% -0.02% ========================================== Files 565 565 Lines 65223 65221 -2 ========================================== - Hits 12346 12333 -13 - Misses 52081 52093 +12 + Partials 796 795 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.