kpango commented 1 month ago

Description

The following modifications have been made to this PR.

Refactoring of IndexManager
- Integration of Index proto into Vald proto
- IndexInfo, IndexDetail, and GetTimestamp APIs are now available outside of Index manager
Automatic Dockerfile generation
- https://github.com/vdaas/vald/blob/refactor/manager-index/small-refactor/hack/docker/gen/main.go
Fixes to Typo
Expose IndexDetail API
Ingress Route optimization
- Added pass-through to LB when using MirrorGateway or FilterGateway as specific API processing is not needed
Add Formatter (crlfmt)
- https://github.com/cockroachdb/crlfmt
Detailing of internal info API 　- Add GoMaxProcs, CGOCall, GoroutineCount, RuntimeCPUCores

Related Issue

Versions

Go Version: 1.22.5
Rust Version: 1.77.2
Docker Version: 20.10.8
Kubernetes Version: v1.30.2
NGT Version: 2.2.2

Checklist

[ ] I have read the CONTRIBUTING document and completed our CLA agreement.
[ ] I have checked open Pull Requests for the similar feature or fixes?

Special notes for your reviewer

kpango commented 1 month ago

@coderabbitai please review

coderabbitai[bot] commented 1 month ago

@kpango, I will review the changes in the pull request.

Actions performed

Review triggered. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

kpango commented 1 month ago

@coderabbitai summary

kpango commented 1 month ago

@coderabbitai full review

coderabbitai[bot] commented 1 month ago

Actions performed

Summary regeneration triggered.

coderabbitai[bot] commented 1 month ago

Actions performed

Full review triggered.

vdaas-ci commented 1 month ago

[CHATOPS:HELP] ChatOps commands.

:ok_woman: /approve - approve
:bento: /format - format codes and add licenses
:white_check_mark: /gen-test - generate test codes
:label: /label - add labels
:end: :two: :end: /label actions/e2e-deploy - run E2E deploy & integration test

coderabbitai[bot] commented 1 month ago

[!IMPORTANT]

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

135 files out of 262 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

vdaas-ci commented 1 month ago

[WARNING:INTCFG] Changes in interal/config may require you to change Helm charts. Please check.

cloudflare-pages[bot] commented 1 month ago

Deploying vald with Cloudflare Pages

Latest commit:	`6ad94c0`
Status:	✅ Deploy successful!
Preview URL:	https://cbc83578.vald.pages.dev
Branch Preview URL:	https://refactor-manager-index-small.vald.pages.dev

View logs

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 4.35699% with 1361 lines in your changes missing coverage. Please review.

Project coverage is 18.42%. Comparing base (f3fbbc2) to head (6ad94c0). Report is 3 commits behind head on main.

Files	Patch %	Lines
hack/docker/gen/main.go	0.00%	335 Missing :warning:
apis/grpc/v1/payload/payload_vtproto.pb.go	0.00%	330 Missing :warning:
internal/client/v1/client/vald/vald.go	0.00%	153 Missing :warning:
apis/grpc/v1/payload/payload.pb.go	5.80%	146 Missing :warning:
apis/grpc/v1/vald/filter_vtproto.pb.go	0.00%	40 Missing :warning:
apis/grpc/v1/vald/search_vtproto.pb.go	0.00%	40 Missing :warning:
apis/grpc/v1/vald/object_vtproto.pb.go	0.00%	33 Missing :warning:
apis/grpc/v1/vald/index_vtproto.pb.go	0.00%	26 Missing :warning:
internal/info/info.go	0.00%	22 Missing :warning:
apis/grpc/v1/rpc/errdetails/error_details.pb.go	0.00%	14 Missing :warning:
... and 61 more

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2525 +/- ## ========================================== - Coverage 18.95% 18.42% -0.54% ========================================== Files 565 566 +1 Lines 65225 66342 +1117 ========================================== - Hits 12364 12223 -141 - Misses 52061 53331 +1270 + Partials 800 788 -12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.