Closed kpango closed 1 month ago
[!IMPORTANT]
Review skipped
Ignore keyword(s) in the title.
Ignored keywords (3)
* WIP * DO NOT MERGE * DNMPlease check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
[CHATOPS:HELP] ChatOps commands.
/approve
- approve/format
- format codes and add licenses/gen-test
- generate test codes/label
- add labels/label actions/e2e-deploy
- run E2E deploy & integration testLatest commit: |
714027d
|
Status: | ✅ Deploy successful! |
Preview URL: | https://898c68e1.vald.pages.dev |
Branch Preview URL: | https://feature-agent-ngt-statistics.vald.pages.dev |
Attention: Patch coverage is 0.94340%
with 315 lines
in your changes missing coverage. Please review.
Project coverage is 7.90%. Comparing base (
76eb8d7
) to head (e445bb1
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
[WARNING:INTCFG] Changes in interal/config
may require you to change Helm charts. Please check.
Description
Summary
This pull request introduces several significant updates and enhancements, primarily focusing on adding new API functionalities for index statistics and improving observability metrics.
The _test.go and pb.go diffs are just re-generated please ignore them.
Changes
Protobuf Updates:
Info.Index.Statistics
toapis/proto/v1/payload/payload.proto
.IndexStatistics
andIndexStatisticsDetail
APIs inapis/proto/v1/vald/index.proto
to returnInfo.Index.Statistics
.Handler Implementations:
IndexStatistics
andIndexStatisticsDetail
API handlers inpkg/gateway/lb/handler/grpc/handler.go
.pkg/agent/core/ngt/service/ngt.go
.Algorithm Enhancements:
GraphStatistics
struct andGetGraphStatistics(m statisticsType) (stats *GraphStatistics, err error)
function ininternal/core/algorithm/ngt/ngt.go
to enable retrieval of index statistics.GraphStatistics
postCreateIndex
based on options inpkg/agent/core/ngt/service/ngt.go
.Metrics Export:
GraphStatistics
metrics ininternal/observability/metrics/agent/core/ngt/ngt.go
.Int64ObservableGauge
andFloat64ObservableGauge
ininternal/observability/metrics/metrics.go
.Configuration and Formatting:
.github/workflows/format.yml
to add ignore settings forFormat and license
.Makefile
underformat/go
to include formatting of artifacts generated fromProto
.Additional Notes
Related Issue
Versions
Checklist
Special notes for your reviewer