vdaas / vald

Vald. A Highly Scalable Distributed Vector Search Engine
https://vald.vdaas.org
Apache License 2.0
1.51k stars 75 forks source link

Introduce an observability crate using opentelemetry-rust #2535

Closed hlts2 closed 1 month ago

hlts2 commented 1 month ago

Description

I Introduced an observability crate using opentelemetry-rust.

Important aspects of design

Since opentelemetry-rust is still under development, interface changes may occur in the future. Therefore, this crate is designed to make the user as unaware of opentelemetry-rust as possible. If the interface is changed in the future, only the macro needs to be modified.

fn child_function(ctx: &opentelemetry::Context, i: i32) { let ctx = ctx_span!(ctx, "child_function"); defer!(ctx.span().end());

ctx.span()
    .set_attribute(KeyValue::new("id", "test")));

}


- The following example is the generation of the metrics.

```rust
# sync
let conter = instrument!(
    InstrumentKind::Counter,
    i64,
    "agent_core_ngt_insert_vqueue_count",
    "Agent NGT insert vqueue count",
    Unit::new("1"),
);
counter.add(11.0, &[]); 

# async
instrument!(
    InstrumentKind::Counter,
    i64,
    "agent_core_ngt_insert_vqueue_count",
    "Agent NGT insert vqueue count",
    Unit::new("1"),
    agent.index_count,
    KeyValue::new("key-1", "value-1"),
);
fn test() {
    let cfg = Config::new()
        .enabled(true)
        .attribute(SERVICE_NAME, "vald-lb-gateway")
        .attribute("target_pod", "target_pod")
        .attribute("target_node", "target_node")
        .attribute("exported_kubernetes_namespace", "default")
        .attribute("kubernetes_name", "vald-lb-gateway")
        .endpoint("http://localhost:2222/")
        .meter(
             Meter::new()
                 .enabled(true)
                 .export_timeout_duration(Duration::from_secs(10)),
         )
        .tracer(Tracer::new().enabled(true));
    let observe = ObservabilityImpl::new(cfg).unwrap();
    // observe.shutdown().unwrap();
}

Related Issue

Versions

Checklist

Special notes for your reviewer

Summary by CodeRabbit

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago

[!IMPORTANT]

Review skipped

Review was skipped due to path filters

Files ignored due to path filters (1) * `rust/Cargo.lock` is excluded by `!**/*.lock`

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough ## Walkthrough This update introduces a new observability library to a Rust workspace, enhancing monitoring and tracing capabilities. Key additions include a `Cargo.toml` for the observability package, configuration structures for observability settings, macros for telemetry management, and core implementations for handling OpenTelemetry. The workspace members have been reorganized to prioritize observability features, facilitating seamless integration and improved performance tracking in applications. ## Changes | Files | Change Summary | |---------------------------------------------------|------------------------------------------------------------------------------------------------------------------| | `rust/Cargo.toml` | Updated workspace `members` to include `libs/observability`, reordering existing members. | | `rust/libs/observability/Cargo.toml` | Introduced `Cargo.toml` defining metadata and dependencies for the new observability package. | | `rust/libs/observability/src/config.rs` | Created configuration structs (`Config`, `Tracer`, `Meter`) with methods for setting observability options. | | `rust/libs/observability/src/lib.rs` | Established module structure with public modules: `config`, `macros`, `observability`. | | `rust/libs/observability/src/macros.rs` | Added macros for telemetry management, such as `tracer!`, `ctx_span!`, and `meter!`. | | `rust/libs/observability/src/observability.rs` | Defined the `Observability` trait and its implementation for managing OpenTelemetry components. | ## Sequence Diagram(s) ```mermaid sequenceDiagram participant App as Application participant Config as Config participant Tracer as Tracer Provider participant Meter as Meter Provider participant Observability as Observability Manager App->>Config: Create configuration Config->>Observability: Build observability Observability->>Tracer: Initialize tracer if enabled Observability->>Meter: Initialize meter if enabled Observability->>App: Ready for telemetry App->>Observability: Shutdown observability Observability->>Tracer: Shutdown tracer Observability->>Meter: Shutdown meter ```

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
vdaas-ci commented 1 month ago

[CHATOPS:HELP] ChatOps commands.

cloudflare-pages[bot] commented 1 month ago

Deploying vald with  Cloudflare Pages  Cloudflare Pages

Latest commit: fcde1cf
Status: ✅  Deploy successful!
Preview URL: https://13e87b74.vald.pages.dev
Branch Preview URL: https://feat-add-otel-rust.vald.pages.dev

View logs

hlts2 commented 1 month ago

@kmrmt @kpango Thank you for your review! I will merge this PR 🚀